git.openwrt.org Git - openwrt/staging/neocturne.git/blob

   1 From 44ad8207806973f4e4f7d870fff36cc01f494250 Mon Sep 17 00:00:00 2001
   2 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
   3 Date: Thu, 13 Jul 2023 13:11:45 +0200
   4 Subject: [PATCH] ARM: dts: BCM53573: Fix Ethernet info for Luxul devices
   5 MIME-Version: 1.0
   6 Content-Type: text/plain; charset=UTF-8
   7 Content-Transfer-Encoding: 8bit
   8
   9 Both Luxul's XAP devices (XAP-810 and XAP-1440) are access points that
  10 use a non-default design. They don't include switch but have a single
  11 Ethernet port and BCM54210E PHY connected to the Ethernet controller's
  12 MDIO bus.
  13
  14 Support for those devices regressed due to two changes:
  15
  16 1. Describing MDIO bus with switch
  17 After commit 9fb90ae6cae7 ("ARM: dts: BCM53573: Describe on-SoC BCM53125
  18 rev 4 switch") Linux stopped probing for MDIO devices.
  19
  20 2. Dropping hardcoded BCM54210E delays
  21 In commit fea7fda7f50a ("net: phy: broadcom: Fix RGMII delays
  22 configuration for BCM54210E") support for other PHY modes was added but
  23 that requires a proper "phy-mode" value in DT.
  24
  25 Both above changes are correct (they don't need to be reverted or
  26 anything) but they need this fix for DT data to be correct and for Linux
  27 to work properly.
  28
  29 Fixes: 9fb90ae6cae7 ("ARM: dts: BCM53573: Describe on-SoC BCM53125 rev 4 switch")
  30 Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
  31 Link: https://lore.kernel.org/r/20230713111145.14864-1-zajec5@gmail.com
  32 Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
  33 ---
  34  .../boot/dts/broadcom/bcm47189-luxul-xap-1440.dts   | 13 +++++++++++++
  35  .../boot/dts/broadcom/bcm47189-luxul-xap-810.dts    | 13 +++++++++++++
  36  2 files changed, 26 insertions(+)
  37
  38 --- a/arch/arm/boot/dts/bcm47189-luxul-xap-1440.dts
  39 +++ b/arch/arm/boot/dts/bcm47189-luxul-xap-1440.dts
  40 @@ -58,3 +58,16 @@
  41                 };
  42         };
  43  };
  44 +
  45 +&gmac0 {
  46 +       phy-mode = "rgmii";
  47 +       phy-handle = <&bcm54210e>;
  48 +
  49 +       mdio {
  50 +               /delete-node/ switch@1e;
  51 +
  52 +               bcm54210e: ethernet-phy@0 {
  53 +                       reg = <0>;
  54 +               };
  55 +       };
  56 +};
  57 --- a/arch/arm/boot/dts/bcm47189-luxul-xap-810.dts
  58 +++ b/arch/arm/boot/dts/bcm47189-luxul-xap-810.dts
  59 @@ -94,3 +94,16 @@
  60                 };
  61         };
  62  };
  63 +
  64 +&gmac0 {
  65 +       phy-mode = "rgmii";
  66 +       phy-handle = <&bcm54210e>;
  67 +
  68 +       mdio {
  69 +               /delete-node/ switch@1e;
  70 +
  71 +               bcm54210e: ethernet-phy@0 {
  72 +                       reg = <0>;
  73 +               };
  74 +       };
  75 +};