git.openwrt.org Git - openwrt/staging/981213.git/blob

   1 From 37e9677654a48cfa748c1d22fbf782920ab2cb23 Mon Sep 17 00:00:00 2001
   2 From: Dave Stevenson <dave.stevenson@raspberrypi.com>
   3 Date: Wed, 29 Apr 2020 22:05:09 +0100
   4 Subject: [PATCH] media: bcm2835-unicam: Do not stop streaming in
   5  unicam_release
   6
   7 unicam_release calls _vb2_fop_release, which will call stop_streaming
   8 if that particular node was streaming. Calling it unconditionally (as
   9 the code was) means that if a second handle was opened eg to alter
  10 a setting, on closing that connection it also stopped Unicam.
  11
  12 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
  13 ---
  14  drivers/media/platform/bcm2835/bcm2835-unicam.c | 3 ---
  15  1 file changed, 3 deletions(-)
  16
  17 --- a/drivers/media/platform/bcm2835/bcm2835-unicam.c
  18 +++ b/drivers/media/platform/bcm2835/bcm2835-unicam.c
  19 @@ -2204,9 +2204,6 @@ static int unicam_release(struct file *f
  20         if (fh_singular)
  21                 v4l2_subdev_call(sd, core, s_power, 0);
  22
  23 -       if (node->streaming)
  24 -               unicam_stop_streaming(&node->buffer_queue);
  25 -
  26         node->open--;
  27         mutex_unlock(&node->lock);
  28