git.openwrt.org Git - openwrt/staging/ynezz.git/blob

   1 From b13487a97b51a619b4e681a6091a1da9d6733058 Mon Sep 17 00:00:00 2001
   2 From: Jason Liu <jason.hui.liu@nxp.com>
   3 Date: Fri, 10 Jan 2020 11:38:05 +0800
   4 Subject: [PATCH] LF-789-1 Revert "scripts: Makefile: Enable creation of
   5  _symbols_ DT node for overlays"
   6
   7 This reverts commit 432071b7a106060fa4e451e10249cef021af0b7c.
   8
   9 commit: 432071b7a106 scripts: Makefile: Enable creation of _symbols_ DT node for overlays
  10 changes the common Makefile and force creation of __symbols__ node on all platforms.
  11
  12 This is not good and not acceptible under some cases due to this change will increase
  13 the final DTB size a lot and bring big impact for others who does not need creation
  14 of _symbols_ DT node for overlays.For example, on i.MX OP-TEE, the maxsize of DT is 1MB,
  15 this patch will break some of the i.MX6/i.MX7 boards to boot with OP-TEE enabled.
  16
  17 BTW, community has the similar patch but rejected. The following post discuss about this:
  18 https://lore.kernel.org/patchwork/patch/821645/
  19
  20 For specifc plaform/board which need the creation of _symbols_ DT node for overlays, user can
  21 define DTC_FLAGS_target either trough dtc build command line(#1) or with board specific Makefile(#2)
  22
  23 For example:#1
  24
  25 make DTC_FLAGS_fsl-ls1028a-qds=-@ freescale/fsl-ls1028a-qds.dtb
  26
  27 For example:#2
  28
  29 In arch/arm64/boot/dts/freescale/Makefile,
  30
  31  @@ -1,4 +1,7 @@
  32   # SPDX-License-Identifier: GPL-2.0
  33  +# required for overlay support
  34  +#DTC_FLAGS_fsl-ls1028a-qds := -@
  35  +
  36
  37 Signed-off-by: Jason Liu <jason.hui.liu@nxp.com>
  38 Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
  39 Reviewed-by: Alex Marginean <alexandru.marginean@nxp.com>
  40 Tested-by: Alex Marginean <alexandru.marginean@nxp.com>
  41 [fix commit message]
  42 Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
  43 ---
  44  scripts/Makefile.lib | 3 ---
  45  1 file changed, 3 deletions(-)
  46
  47 --- a/scripts/Makefile.lib
  48 +++ b/scripts/Makefile.lib
  49 @@ -255,9 +255,6 @@ endif
  50
  51  DTC_FLAGS += $(DTC_FLAGS_$(basetarget))
  52
  53 -# Enable creation of _symbols_ node for DT overlays
  54 -DTC_FLAGS += -@
  55 -
  56  # Generate an assembly file to wrap the output of the device tree compiler
  57  quiet_cmd_dt_S_dtb= DTB     $@
  58  cmd_dt_S_dtb=                                          \