git.openwrt.org Git - openwrt/staging/wigyori.git/blob

   1 From patchwork Tue Sep 17 13:49:55 2024
   2 Content-Type: text/plain; charset="utf-8"
   3 MIME-Version: 1.0
   4 Content-Transfer-Encoding: 7bit
   5 X-Patchwork-Submitter: Daniel Golle <daniel@makrotopia.org>
   6 X-Patchwork-Id: 13806177
   7 X-Patchwork-Delegate: kuba@kernel.org
   8 Date: Tue, 17 Sep 2024 14:49:55 +0100
   9 From: Daniel Golle <daniel@makrotopia.org>
  10 To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>,
  11         Russell King <linux@armlinux.org.uk>,
  12         "David S. Miller" <davem@davemloft.net>,
  13         Eric Dumazet <edumazet@google.com>,
  14         Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
  15         Daniel Golle <daniel@makrotopia.org>,
  16         Christian Marangi <ansuelsmth@gmail.com>,
  17         Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
  18         Robert Marko <robimarko@gmail.com>,
  19         Russell King <rmk+kernel@armlinux.org.uk>, netdev@vger.kernel.org,
  20         linux-kernel@vger.kernel.org
  21 Subject: [PATCH net 2/2] net: phy: aquantia: fix applying active_low bit
  22  after reset
  23 Message-ID:
  24  <9b1f0cd91f4cda54c8be56b4fe780480baf4aa0f.1726580902.git.daniel@makrotopia.org>
  25 References:
  26  <ab963584b0a7e3b4dac39472a4b82ca264d79630.1726580902.git.daniel@makrotopia.org>
  27 Precedence: bulk
  28 X-Mailing-List: netdev@vger.kernel.org
  29 List-Id: <netdev.vger.kernel.org>
  30 List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
  31 List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
  32 MIME-Version: 1.0
  33 Content-Disposition: inline
  34 In-Reply-To:
  35  <ab963584b0a7e3b4dac39472a4b82ca264d79630.1726580902.git.daniel@makrotopia.org>
  36 X-Patchwork-Delegate: kuba@kernel.org
  37
  38 for_each_set_bit was used wrongly in aqr107_config_init() when iterating
  39 over LEDs. Drop misleading 'index' variable and call
  40 aqr_phy_led_active_low_set() for each set bit representing an LED which
  41 is driven by VDD instead of GND pin.
  42
  43 Fixes: 61578f679378 ("net: phy: aquantia: add support for PHY LEDs")
  44 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
  45 Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  46 ---
  47  drivers/net/phy/aquantia/aquantia_main.c | 5 ++---
  48  1 file changed, 2 insertions(+), 3 deletions(-)
  49
  50 --- a/drivers/net/phy/aquantia/aquantia_main.c
  51 +++ b/drivers/net/phy/aquantia/aquantia_main.c
  52 @@ -530,7 +530,7 @@ static int aqr107_config_init(struct phy
  53  {
  54         struct aqr107_priv *priv = phydev->priv;
  55         u32 led_active_low;
  56 -       int ret, index = 0;
  57 +       int ret;
  58
  59         /* Check that the PHY interface type is compatible */
  60         if (phydev->interface != PHY_INTERFACE_MODE_SGMII &&
  61 @@ -570,10 +570,9 @@ static int aqr107_config_init(struct phy
  62
  63         /* Restore LED polarity state after reset */
  64         for_each_set_bit(led_active_low, &priv->leds_active_low, AQR_MAX_LEDS) {
  65 -               ret = aqr_phy_led_active_low_set(phydev, index, led_active_low);
  66 +               ret = aqr_phy_led_active_low_set(phydev, led_active_low, true);
  67                 if (ret)
  68                         return ret;
  69 -               index++;
  70         }
  71
  72         return 0;