git.openwrt.org Git - openwrt/staging/neocturne.git/blob

   1 From a8642cd11635a35a5f1dc31857887900d6610778 Mon Sep 17 00:00:00 2001
   2 From: Tom Rix <trix@redhat.com>
   3 Date: Tue, 4 Apr 2023 18:21:48 +0100
   4 Subject: [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout
   5  storage-class-specifier to static
   6
   7 smatch reports
   8 drivers/nvmem/layouts/sl28vpd.c:144:21: warning: symbol
   9   'sl28vpd_layout' was not declared. Should it be static?
  10
  11 This variable is only used in one file so it should be static.
  12
  13 Signed-off-by: Tom Rix <trix@redhat.com>
  14 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  15 Link: https://lore.kernel.org/r/20230404172148.82422-41-srinivas.kandagatla@linaro.org
  16 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  17 ---
  18  drivers/nvmem/layouts/sl28vpd.c | 2 +-
  19  1 file changed, 1 insertion(+), 1 deletion(-)
  20
  21 --- a/drivers/nvmem/layouts/sl28vpd.c
  22 +++ b/drivers/nvmem/layouts/sl28vpd.c
  23 @@ -141,7 +141,7 @@ static const struct of_device_id sl28vpd
  24  };
  25  MODULE_DEVICE_TABLE(of, sl28vpd_of_match_table);
  26
  27 -struct nvmem_layout sl28vpd_layout = {
  28 +static struct nvmem_layout sl28vpd_layout = {
  29         .name = "sl28-vpd",
  30         .of_match_table = sl28vpd_of_match_table,
  31         .add_cells = sl28vpd_add_cells,