git.openwrt.org Git - openwrt/staging/ldir.git/blob

   1 From 89ec9bbe60b61cc6ae3eddd6d4f43e128f8a88de Mon Sep 17 00:00:00 2001
   2 From: Shiji Yang <yangshiji66@outlook.com>
   3 Date: Tue, 20 Jun 2023 18:43:23 +0800
   4 Subject: [PATCH 2/2] mips: pci-mt7620: use dev_info() to log PCIe device
   5  detection result
   6
   7 Usually, We only need to print the error log when there is a PCIe card but
   8 initialization fails. Whether the driver finds the PCIe card or not is the
   9 expected behavior. So it's better to log these information with dev_info().
  10
  11 Tested on MT7628AN router Motorola MWR03.
  12
  13 Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
  14 Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
  15 Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  16 ---
  17  arch/mips/pci/pci-mt7620.c | 4 ++--
  18  1 file changed, 2 insertions(+), 2 deletions(-)
  19
  20 --- a/arch/mips/pci/pci-mt7620.c
  21 +++ b/arch/mips/pci/pci-mt7620.c
  22 @@ -331,7 +331,7 @@ static int mt7620_pci_probe(struct platf
  23                 rt_sysc_m32(RALINK_PCIE0_CLK_EN, 0, RALINK_CLKCFG1);
  24                 if (ralink_soc == MT762X_SOC_MT7620A)
  25                         rt_sysc_m32(LC_CKDRVPD, PDRV_SW_SET, PPLL_DRV);
  26 -               dev_err(&pdev->dev, "PCIE0 no card, disable it(RST&CLK)\n");
  27 +               dev_info(&pdev->dev, "PCIE0 no card, disable it(RST&CLK)\n");
  28                 return -1;
  29         }
  30
  31 @@ -374,7 +374,7 @@ int pcibios_map_irq(const struct pci_dev
  32                         dev->bus->number, slot);
  33                 return 0;
  34         }
  35 -       dev_err(&dev->dev, "card - bus=0x%x, slot = 0x%x irq=%d\n",
  36 +       dev_info(&dev->dev, "card - bus=0x%x, slot = 0x%x irq=%d\n",
  37                 dev->bus->number, slot, irq);
  38
  39         /* configure the cache line size to 0x14 */