git.openwrt.org Git - openwrt/staging/xback.git/blob

   1 From d3524bb5b9a0c567b853a0024526afe87dde01ed Mon Sep 17 00:00:00 2001
   2 From: Kenneth Lee <klee33@uw.edu>
   3 Date: Fri, 16 Sep 2022 13:20:52 +0100
   4 Subject: [PATCH] nvmem: brcm_nvram: Use kzalloc for allocating only one
   5  element
   6
   7 Use kzalloc(...) rather than kcalloc(1, ...) because the number of
   8 elements we are specifying in this case is 1, so kzalloc would
   9 accomplish the same thing and we can simplify.
  10
  11 Signed-off-by: Kenneth Lee <klee33@uw.edu>
  12 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  13 Link: https://lore.kernel.org/r/20220916122100.170016-6-srinivas.kandagatla@linaro.org
  14 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  15 ---
  16  drivers/nvmem/brcm_nvram.c | 2 +-
  17  1 file changed, 1 insertion(+), 1 deletion(-)
  18
  19 --- a/drivers/nvmem/brcm_nvram.c
  20 +++ b/drivers/nvmem/brcm_nvram.c
  21 @@ -96,7 +96,7 @@ static int brcm_nvram_parse(struct brcm_
  22
  23         len = le32_to_cpu(header.len);
  24
  25 -       data = kcalloc(1, len, GFP_KERNEL);
  26 +       data = kzalloc(len, GFP_KERNEL);
  27         memcpy_fromio(data, priv->base, len);
  28         data[len - 1] = '\0';
  29