git.openwrt.org Git - openwrt/openwrt.git/blob

   1 From a9c640d91233d2e1b38e32644a5f53bc2de1fce0 Mon Sep 17 00:00:00 2001
   2 From: Maxime Ripard <maxime@cerno.tech>
   3 Date: Thu, 29 Apr 2021 21:58:27 +0200
   4 Subject: [PATCH] drm/vc4: hdmi: Simplify the connector state retrieval
   5
   6 When we have the entire DRM state, retrieving the connector state only
   7 requires the drm_connector pointer. Fortunately for us, we have
   8 allocated it as a part of the vc4_hdmi structure, so we can retrieve get
   9 a pointer by simply accessing our field in that structure.
  10
  11 Signed-off-by: Maxime Ripard <maxime@cerno.tech>
  12 ---
  13  drivers/gpu/drm/vc4/vc4_hdmi.c | 21 +++------------------
  14  1 file changed, 3 insertions(+), 18 deletions(-)
  15
  16 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
  17 +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
  18 @@ -851,31 +851,16 @@ static void vc4_hdmi_recenter_fifo(struc
  19                   "VC4_HDMI_FIFO_CTL_RECENTER_DONE");
  20  }
  21
  22 -static struct drm_connector_state *
  23 -vc4_hdmi_encoder_get_connector_state(struct drm_encoder *encoder,
  24 -                                    struct drm_atomic_state *state)
  25 -{
  26 -       struct drm_connector_state *conn_state;
  27 -       struct drm_connector *connector;
  28 -       unsigned int i;
  29 -
  30 -       for_each_new_connector_in_state(state, connector, conn_state, i) {
  31 -               if (conn_state->best_encoder == encoder)
  32 -                       return conn_state;
  33 -       }
  34 -
  35 -       return NULL;
  36 -}
  37 -
  38  static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder,
  39                                                 struct drm_atomic_state *state)
  40  {
  41 +       struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
  42 +       struct drm_connector *connector = &vc4_hdmi->connector;
  43         struct drm_connector_state *conn_state =
  44 -               vc4_hdmi_encoder_get_connector_state(encoder, state);
  45 +               drm_atomic_get_new_connector_state(state, connector);
  46         struct vc4_hdmi_connector_state *vc4_conn_state =
  47                 conn_state_to_vc4_hdmi_conn_state(conn_state);
  48         struct drm_display_mode *mode = &encoder->crtc->state->adjusted_mode;
  49 -       struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
  50         unsigned long bvb_rate, pixel_rate, hsm_rate;
  51         int ret;
  52