git.openwrt.org Git - openwrt/staging/xback.git/blob

   1 From a329773522953892d9bb4548482d42fc93fea329 Mon Sep 17 00:00:00 2001
   2 From: David Bauer <mail@david-bauer.net>
   3 Date: Thu, 27 Jun 2024 18:45:19 +0200
   4 Subject: [PATCH] AP: don't ignore probe-requests with invalid DSSS params
   5
   6 Don't ignore probe requests which contain an invalid DS parameter for the
   7 current operating channel.
   8
   9 As the comment outlines, the drop shall only apply if
  10 dot11RadioMeasurementActivated is set to 1.
  11
  12 However, it was observed Linux clients (Debian 12 / NixOS 23.11)
  13 with an Intel 8265 NIC may generate a probe request frame with
  14 dot11RadioMeasurementActivated set to false and an invalid DSSS
  15 parameter.
  16
  17 These were also dropped even though they should not have been. They
  18 however should not have contained this parameter in the first place.
  19
  20 Don't drop Probe Requests which contain such an invalid field. This may
  21 lead to more probe responses being sent, however it does fix very
  22 frequent connection issues for these clients on 2.4 GHz.
  23
  24 Signed-off-by: David Bauer <mail@david-bauer.net>
  25 ---
  26  src/ap/beacon.c | 2 +-
  27  1 file changed, 1 insertion(+), 1 deletion(-)
  28
  29 diff --git a/src/ap/beacon.c b/src/ap/beacon.c
  30 index 8cd1c4170..bb9329085 100644
  31 --- a/src/ap/beacon.c
  32 +++ b/src/ap/beacon.c
  33 @@ -905,7 +905,7 @@ void handle_probe_req(struct hostapd_data *hapd,
  34          * is less likely to see them (Probe Request frame sent on a
  35          * neighboring, but partially overlapping, channel).
  36          */
  37 -       if (elems.ds_params &&
  38 +       if (elems.ds_params && 0 &&
  39             hapd->iface->current_mode &&
  40             (hapd->iface->current_mode->mode == HOSTAPD_MODE_IEEE80211G ||
  41              hapd->iface->current_mode->mode == HOSTAPD_MODE_IEEE80211B) &&
  42 --
  43 2.43.0
  44