git.openwrt.org Git - openwrt/staging/pepe2k.git/blob

   1 From dd0f15fc877c10567699190bce0f55e96f4ad6b5 Mon Sep 17 00:00:00 2001
   2 From: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= <arinc.unal@arinc9.com>
   3 Date: Mon, 22 Apr 2024 10:15:17 +0300
   4 Subject: [PATCH 10/15] net: dsa: mt7530: get rid of function sanity check
   5 MIME-Version: 1.0
   6 Content-Type: text/plain; charset=UTF-8
   7 Content-Transfer-Encoding: 8bit
   8
   9 Get rid of checking whether functions are filled properly. priv->info which
  10 is an mt753x_info structure is filled and checked for before this check.
  11 It's unnecessary checking whether it's filled properly.
  12
  13 Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
  14 ---
  15  drivers/net/dsa/mt7530.c | 7 -------
  16  1 file changed, 7 deletions(-)
  17
  18 --- a/drivers/net/dsa/mt7530.c
  19 +++ b/drivers/net/dsa/mt7530.c
  20 @@ -3235,13 +3235,6 @@ mt7530_probe_common(struct mt7530_priv *
  21         if (!priv->info)
  22                 return -EINVAL;
  23
  24 -       /* Sanity check if these required device operations are filled
  25 -        * properly.
  26 -        */
  27 -       if (!priv->info->sw_setup || !priv->info->phy_read ||
  28 -           !priv->info->phy_write || !priv->info->mac_port_get_caps)
  29 -               return -EINVAL;
  30 -
  31         priv->id = priv->info->id;
  32         priv->dev = dev;
  33         priv->ds->priv = priv;