36f5584ddddb27eef955e4d958078b699368cd94
[openwrt/staging/luka.git] /
1 From d661bf1a882cc7123f84fcf3ccf210b19929a47b Mon Sep 17 00:00:00 2001
2 From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
3 Date: Fri, 1 Jun 2018 13:10:02 +0200
4 Subject: [PATCH 384/454] staging: vc04_services: remove struct
5 vchiq_debugfs_info
6
7 commit 127892febb2d5d6612756da2d7d0bab526db3b51 upstream
8
9 This structure, and the one static variable that was declared with it,
10 were not being used for anything. The log_categories field was being
11 set, but never used again. So just remove it entirely as it is not
12 needed at all.
13
14 Suggested-by: Eric Anholt <eric@anholt.net>
15 Cc: Stefan Wahren <stefan.wahren@i2se.com>
16 Cc: Kees Cook <keescook@chromium.org>
17 Cc: Dan Carpenter <dan.carpenter@oracle.com>
18 Cc: Arnd Bergmann <arnd@arndb.de>
19 Cc: Keerthi Reddy <keerthigd4990@gmail.com>
20 Cc: linux-rpi-kernel@lists.infradead.org
21 Cc: linux-arm-kernel@lists.infradead.org
22 Reviewed-by: Eric Anholt <eric@anholt.net>
23 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
24 ---
25 .../interface/vchiq_arm/vchiq_debugfs.c | 15 +--------------
26 1 file changed, 1 insertion(+), 14 deletions(-)
27
28 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c
29 +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c
30 @@ -52,15 +52,6 @@
31 #define VCHIQ_LOG_INFO_STR "info"
32 #define VCHIQ_LOG_TRACE_STR "trace"
33
34 -
35 -/* Top-level debug info */
36 -struct vchiq_debugfs_info {
37 - /* log categories */
38 - struct dentry *log_categories;
39 -};
40 -
41 -static struct vchiq_debugfs_info debugfs_info;
42 -
43 /* Global 'vchiq' debugfs and clients entry used by all instances */
44 struct dentry *vchiq_dbg_dir;
45 struct dentry *vchiq_dbg_clients;
46 @@ -161,16 +152,12 @@ static void vchiq_debugfs_create_log_ent
47 size_t i;
48
49 dir = debugfs_create_dir("log", vchiq_dbg_dir);
50 - debugfs_info.log_categories = dir;
51
52 for (i = 0; i < n_log_entries; i++) {
53 void *levp = (void *)vchiq_debugfs_log_entries[i].plevel;
54
55 dir = debugfs_create_file(vchiq_debugfs_log_entries[i].name,
56 - 0644,
57 - debugfs_info.log_categories,
58 - levp,
59 - &debugfs_log_fops);
60 + 0644, dir, levp, &debugfs_log_fops);
61 vchiq_debugfs_log_entries[i].dir = dir;
62 }
63 }