git.openwrt.org Git - openwrt/staging/blogic.git/blob

   1 From 3637d49e11219512920aca8b8ccd0994be33fa8b Mon Sep 17 00:00:00 2001
   2 From: Lee Jones <lee.jones@linaro.org>
   3 Date: Thu, 18 Mar 2021 10:40:30 +0000
   4 Subject: [PATCH] of: base: Fix some formatting issues and provide missing
   5  descriptions
   6
   7 Fixes the following W=1 kernel build warning(s):
   8
   9  drivers/of/base.c:315: warning: Function parameter or member 'cpun' not described in '__of_find_n_match_cpu_property'
  10  drivers/of/base.c:315: warning: Function parameter or member 'prop_name' not described in '__of_find_n_match_cpu_property'
  11  drivers/of/base.c:315: warning: Function parameter or member 'cpu' not described in '__of_find_n_match_cpu_property'
  12  drivers/of/base.c:315: warning: Function parameter or member 'thread' not described in '__of_find_n_match_cpu_property'
  13  drivers/of/base.c:315: warning: expecting prototype for property holds the physical id of the(). Prototype was for __of_find_n_match_cpu_property() instead
  14  drivers/of/base.c:1139: warning: Function parameter or member 'match' not described in 'of_find_matching_node_and_match'
  15  drivers/of/base.c:1779: warning: Function parameter or member 'np' not described in '__of_add_property'
  16  drivers/of/base.c:1779: warning: Function parameter or member 'prop' not described in '__of_add_property'
  17  drivers/of/base.c:1800: warning: Function parameter or member 'np' not described in 'of_add_property'
  18  drivers/of/base.c:1800: warning: Function parameter or member 'prop' not described in 'of_add_property'
  19  drivers/of/base.c:1849: warning: Function parameter or member 'np' not described in 'of_remove_property'
  20  drivers/of/base.c:1849: warning: Function parameter or member 'prop' not described in 'of_remove_property'
  21  drivers/of/base.c:2137: warning: Function parameter or member 'dn' not described in 'of_console_check'
  22  drivers/of/base.c:2137: warning: Function parameter or member 'name' not described in 'of_console_check'
  23  drivers/of/base.c:2137: warning: Function parameter or member 'index' not described in 'of_console_check'
  24
  25 Cc: Rob Herring <robh+dt@kernel.org>
  26 Cc: Frank Rowand <frowand.list@gmail.com>
  27 Cc: "David S. Miller" <davem@davemloft.net>
  28 Cc: devicetree@vger.kernel.org
  29 Signed-off-by: Lee Jones <lee.jones@linaro.org>
  30 Signed-off-by: Rob Herring <robh@kernel.org>
  31 Link: https://lore.kernel.org/r/20210318104036.3175910-5-lee.jones@linaro.org
  32 ---
  33  drivers/of/base.c | 16 +++++++++++-----
  34  1 file changed, 11 insertions(+), 5 deletions(-)
  35
  36 --- a/drivers/of/base.c
  37 +++ b/drivers/of/base.c
  38 @@ -305,7 +305,7 @@ bool __weak arch_match_cpu_phys_id(int c
  39         return (u32)phys_id == cpu;
  40  }
  41
  42 -/**
  43 +/*
  44   * Checks if the given "prop_name" property holds the physical id of the
  45   * core/thread corresponding to the logical cpu 'cpu'. If 'thread' is not
  46   * NULL, local thread number within the core is returned in it.
  47 @@ -1128,7 +1128,7 @@ EXPORT_SYMBOL(of_match_node);
  48   *                     will; typically, you pass what the previous call
  49   *                     returned. of_node_put() will be called on it
  50   *     @matches:       array of of device match structures to search in
  51 - *     @match          Updated to point at the matches entry which matched
  52 + *     @match:         Updated to point at the matches entry which matched
  53   *
  54   *     Returns a node pointer with refcount incremented, use
  55   *     of_node_put() on it when done.
  56 @@ -1779,6 +1779,8 @@ EXPORT_SYMBOL(of_count_phandle_with_args
  57
  58  /**
  59   * __of_add_property - Add a property to a node without lock operations
  60 + * @np:                Caller's Device Node
  61 + * @prob:      Property to add
  62   */
  63  int __of_add_property(struct device_node *np, struct property *prop)
  64  {
  65 @@ -1800,6 +1802,8 @@ int __of_add_property(struct device_node
  66
  67  /**
  68   * of_add_property - Add a property to a node
  69 + * @np:                Caller's Device Node
  70 + * @prob:      Property to add
  71   */
  72  int of_add_property(struct device_node *np, struct property *prop)
  73  {
  74 @@ -1844,6 +1848,8 @@ int __of_remove_property(struct device_n
  75
  76  /**
  77   * of_remove_property - Remove a property from a node.
  78 + * @np:                Caller's Device Node
  79 + * @prob:      Property to remove
  80   *
  81   * Note that we don't actually remove it, since we have given out
  82   * who-knows-how-many pointers to the data using get-property.
  83 @@ -2130,9 +2136,9 @@ EXPORT_SYMBOL_GPL(of_alias_get_highest_i
  84
  85  /**
  86   * of_console_check() - Test and setup console for DT setup
  87 - * @dn - Pointer to device node
  88 - * @name - Name to use for preferred console without index. ex. "ttyS"
  89 - * @index - Index to use for preferred console.
  90 + * @dn: Pointer to device node
  91 + * @name: Name to use for preferred console without index. ex. "ttyS"
  92 + * @index: Index to use for preferred console.
  93   *
  94   * Check if the given device node matches the stdout-path property in the
  95   * /chosen node. If it does then register it as the preferred console and return