317f9fbea1d4aec9cebefb19151551a1cbc6ab31
[openwrt/staging/ldir.git] /
1 From 6f0bbf91998cb04030731bc8b254209345cbe9f1 Mon Sep 17 00:00:00 2001
2 From: Dave Stevenson <dave.stevenson@raspberrypi.com>
3 Date: Fri, 12 Feb 2021 17:31:37 +0000
4 Subject: [PATCH] drm/vc4: Change the default DPI format to being
5 18bpp, not 24.
6
7 DPI hasn't really been used up until now, so the default has
8 been meaningless.
9 In theory we should be able to pass the desired format for the
10 adjacent bridge chip through, but framework seems to be missing
11 for that.
12
13 As the main device to use DPI is the VGA666 or Adafruit Kippah,
14 both of which use RGB666, change the default to being RGB666 instead
15 of RGB888.
16
17 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
18 ---
19 drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++--
20 1 file changed, 2 insertions(+), 2 deletions(-)
21
22 --- a/drivers/gpu/drm/vc4/vc4_dpi.c
23 +++ b/drivers/gpu/drm/vc4/vc4_dpi.c
24 @@ -150,8 +150,8 @@ static void vc4_dpi_encoder_enable(struc
25 }
26 drm_connector_list_iter_end(&conn_iter);
27
28 - /* Default to 24bit if no connector or format found. */
29 - dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB, DPI_FORMAT);
30 + /* Default to 18bit if no connector or format found. */
31 + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, DPI_FORMAT);
32
33 if (connector) {
34 if (connector->display_info.num_bus_formats) {