git.openwrt.org Git - openwrt/staging/rmilecki.git/blob

   1 From 12acd136913ccdf394eeb2bc8686ff5505368119 Mon Sep 17 00:00:00 2001
   2 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
   3 Date: Thu, 12 Oct 2017 10:21:26 +0200
   4 Subject: [PATCH] net: bgmac: enable master mode for BCM54210E and B50212E PHYs
   5 MIME-Version: 1.0
   6 Content-Type: text/plain; charset=UTF-8
   7 Content-Transfer-Encoding: 8bit
   8
   9 There are 4 very similar PHYs:
  10 0x600d84a1: BCM54210E (rev B0)
  11 0x600d84a2: BCM54210E (rev B1)
  12 0x600d84a5: B50212E (rev B0)
  13 0x600d84a6: B50212E (rev B1)
  14 that need setting master mode manually. It's because they run in slave
  15 mode by default with Automatic Slave/Master configuration disabled which
  16 can lead to unreliable connection with massive ping loss.
  17
  18 So far it was reported for a board with BCM47189 SoC and B50212E B1 PHY
  19 connected to the bgmac supported ethernet device. Telling PHY driver to
  20 setup PHY properly solves this issue.
  21
  22 Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
  23 Signed-off-by: David S. Miller <davem@davemloft.net>
  24 ---
  25  drivers/net/ethernet/broadcom/bgmac-bcma.c | 8 +++++++-
  26  1 file changed, 7 insertions(+), 1 deletion(-)
  27
  28 --- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
  29 +++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
  30 @@ -159,13 +159,19 @@ static int bgmac_probe(struct bcma_devic
  31
  32         if (!bgmac_is_bcm4707_family(core) &&
  33             !(ci->id == BCMA_CHIP_ID_BCM53573 && core->core_unit == 1)) {
  34 +               struct phy_device *phydev;
  35 +
  36                 mii_bus = bcma_mdio_mii_register(bgmac);
  37                 if (IS_ERR(mii_bus)) {
  38                         err = PTR_ERR(mii_bus);
  39                         goto err;
  40                 }
  41 -
  42                 bgmac->mii_bus = mii_bus;
  43 +
  44 +               phydev = bgmac->mii_bus->phy_map[bgmac->phyaddr];
  45 +               if (ci->id == BCMA_CHIP_ID_BCM53573 && phydev &&
  46 +                   (phydev->drv->phy_id & phydev->drv->phy_id_mask) == PHY_ID_BCM54210E)
  47 +                       phydev->dev_flags |= PHY_BRCM_EN_MASTER_MODE;
  48         }
  49
  50         if (core->bus->hosttype == BCMA_HOSTTYPE_PCI) {