git.openwrt.org Git - openwrt/staging/xback.git/blob

   1 From ed3725e15a154ebebf44e0c34806c57525483f92 Mon Sep 17 00:00:00 2001
   2 From: Rahul Bhattacharjee <quic_rbhattac@quicinc.com>
   3 Date: Fri, 21 Oct 2022 14:31:26 +0530
   4 Subject: [PATCH] wifi: ath11k: Fix qmi_msg_handler data structure
   5  initialization
   6
   7 qmi_msg_handler is required to be null terminated by QMI module.
   8 There might be a case where a handler for a msg id is not present in the
   9 handlers array which can lead to infinite loop while searching the handler
  10 and therefore out of bound access in qmi_invoke_handler().
  11 Hence update the initialization in qmi_msg_handler data structure.
  12
  13 Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
  14
  15 Signed-off-by: Rahul Bhattacharjee <quic_rbhattac@quicinc.com>
  16 Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
  17 Link: https://lore.kernel.org/r/20221021090126.28626-1-quic_rbhattac@quicinc.com
  18 ---
  19  drivers/net/wireless/ath/ath11k/qmi.c | 3 +++
  20  1 file changed, 3 insertions(+)
  21
  22 --- a/drivers/net/wireless/ath/ath11k/qmi.c
  23 +++ b/drivers/net/wireless/ath/ath11k/qmi.c
  24 @@ -3090,6 +3090,9 @@ static const struct qmi_msg_handler ath1
  25                         sizeof(struct qmi_wlfw_fw_init_done_ind_msg_v01),
  26                 .fn = ath11k_qmi_msg_fw_init_done_cb,
  27         },
  28 +
  29 +       /* end of list */
  30 +       {},
  31  };
  32
  33  static int ath11k_qmi_ops_new_server(struct qmi_handle *qmi_hdl,