git.openwrt.org Git - openwrt/staging/neocturne.git/blob

   1 From: Felix Fietkau <nbd@nbd.name>
   2 Date: Thu, 2 Dec 2021 13:30:05 +0100
   3 Subject: [PATCH] mac80211: send ADDBA requests using the tid/queue of the
   4  aggregation session
   5
   6 Sending them out on a different queue can cause a race condition where a
   7 number of packets in the queue may be discarded by the receiver, because
   8 the ADDBA request is sent too early.
   9 This affects any driver with software A-MPDU setup which does not allocate
  10 packet seqno in hardware on tx, regardless of whether iTXQ is used or not.
  11 The only driver I've seen that explicitly deals with this issue internally
  12 is mwl8k.
  13
  14 Cc: stable@vger.kernel.org
  15 Signed-off-by: Felix Fietkau <nbd@nbd.name>
  16 ---
  17
  18 --- a/net/mac80211/agg-tx.c
  19 +++ b/net/mac80211/agg-tx.c
  20 @@ -106,7 +106,7 @@ static void ieee80211_send_addba_request
  21         mgmt->u.action.u.addba_req.start_seq_num =
  22                                         cpu_to_le16(start_seq_num << 4);
  23
  24 -       ieee80211_tx_skb(sdata, skb);
  25 +       ieee80211_tx_skb_tid(sdata, skb, tid);
  26  }
  27
  28  void ieee80211_send_bar(struct ieee80211_vif *vif, u8 *ra, u16 tid, u16 ssn)