git.openwrt.org Git - openwrt/staging/ldir.git/blob

   1 From 4d7b17712513710778c0f2f83ea5d9b55ed58c36 Mon Sep 17 00:00:00 2001
   2 From: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= <arinc.unal@arinc9.com>
   3 Date: Tue, 6 Feb 2024 01:08:08 +0300
   4 Subject: [PATCH 18/30] net: dsa: mt7530: do not clear
   5  config->supported_interfaces
   6 MIME-Version: 1.0
   7 Content-Type: text/plain; charset=UTF-8
   8 Content-Transfer-Encoding: 8bit
   9
  10 There's no need to clear the config->supported_interfaces bitmap before
  11 reporting the supported interfaces as all bits in the bitmap will already
  12 be initialized to zero when the phylink_config structure is allocated. The
  13 "config" pointer points to &dp->phylink_config, and "dp" is allocated by
  14 dsa_port_touch() with kzalloc(), so all its fields are filled with zeroes.
  15
  16 There's no code that would change the bitmap beforehand. Remove it.
  17
  18 Acked-by: Daniel Golle <daniel@makrotopia.org>
  19 Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
  20 Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  21 Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
  22 Link: https://lore.kernel.org/r/20240206-for-netnext-mt7530-improvements-2-v5-7-d7d92a185cb1@arinc9.com
  23 Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  24 ---
  25  drivers/net/dsa/mt7530.c | 2 --
  26  1 file changed, 2 deletions(-)
  27
  28 --- a/drivers/net/dsa/mt7530.c
  29 +++ b/drivers/net/dsa/mt7530.c
  30 @@ -2770,8 +2770,6 @@ static void mt7531_mac_port_get_caps(str
  31  static void mt7988_mac_port_get_caps(struct dsa_switch *ds, int port,
  32                                      struct phylink_config *config)
  33  {
  34 -       phy_interface_zero(config->supported_interfaces);
  35 -
  36         switch (port) {
  37         /* Ports which are connected to switch PHYs. There is no MII pinout. */
  38         case 0 ... 3: