1 From: Sebastian Gottschall <s.gottschall@newmedia-net.de>
3 Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based
4 chipsets with on chipset connected led's using WMI Firmware API. The LED
5 device will get available named as "ath10k-phyX" at sysfs and can be controlled
6 with various triggers. adds also debugfs interface for gpio control.
8 This patch is specific for OpenWRt base, as is use old backported package
9 with old wireless source. Support for QCA9984 is removed.
10 Reworked to use ath10k-ct custom source
13 Signed-off-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
14 Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
15 [kvalo: major reorg and cleanup]
16 Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
17 Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
22 * only compile tested!
24 * fix all checkpatch warnings
28 * sizeof(struct ath10k_gpiocontrol) -> sizeof(*gpio)
30 * unsigned -> unsigned int
32 * remove GPIOLIB code, that should be added in a separate patch
34 * rename gpio.c to leds.c
38 * rename some functions:
40 ath10k_attach_led() -> ath10k_leds_register()
41 ath10k_unregister_led() -> ath10k_leds_unregister()
42 ath10k_reset_led_pin() -> ath10k_leds_start()
44 * call ath10k_leds_unregister() before ath10k_thermal_unregister() to preserve ordering
46 * call ath10k_leds_start() only from ath10k_core_start() and not from mac.c
48 * rename struct ath10k_gpiocontrol as anonymous function under struct
49 ath10k::leds, no need for memory allocation
51 * merge ath10k_add_led() to ath10k_attach_led(), which is it's only caller
53 * remove #if IS_ENABLED() checks from most of places, memory savings from those were not worth it
55 * Kconfig help text improvement and move it lower in the menu, also don't enable it by default
57 * switch to set_brightness_blocking() so that the callback can sleep,
58 then no need to use ath10k_wmi_cmd_send_nowait() and can take mutex
61 * don't touch ath10k_wmi_pdev_get_temperature()
63 * as QCA6174/QCA9377 are not (yet) supported don't add the command to WMI-TLV interface
65 * remove debugfs interface, that should be added in another patch
70 ath10k-4.16/Kconfig | 10 +++
71 ath10k-4.16/Makefile | 1 +
72 ath10k-4.16/core.c | 22 +++++++
73 ath10k-4.16/core.h | 9 ++-
74 ath10k-4.16/hw.h | 1 +
75 ath10k-4.16/leds.c | 103 ++++++++++++++++++++++++++++++
76 ath10k-4.16/leds.h | 45 +++++++++++++
77 ath10k-4.16/mac.c | 1 +
78 ath10k-4.16/wmi-ops.h | 32 ++++++++++
79 ath10k-4.16/wmi-tlv.c | 2 +
80 ath10k-4.16/wmi.c | 54 ++++++++++++++++
81 ath10k-4.16/wmi.h | 35 ++++++++++
82 12 files changed, 314 insertions(+), 1 deletion(-)
83 create mode 100644 ath10k-4.16/leds.c
84 create mode 100644 ath10k-4.16/leds.h
85 --- a/ath10k-4.16/Kconfig
86 +++ b/ath10k-4.16/Kconfig
87 @@ -60,6 +60,16 @@ config ATH10K_SPECTRAL
89 Say Y to enable access to the FFT/spectral data via debugfs.
92 + bool "Atheros ath10k LED support"
94 + select MAC80211_LEDS
99 + This option is necessary, if you want LED support for chipset connected led pins. If unsure, say N.
101 config ATH10K_TRACING
102 bool "Atheros ath10k tracing support"
104 --- a/ath10k-4.16/Makefile
105 +++ b/ath10k-4.16/Makefile
106 @@ -19,6 +19,7 @@ ath10k_core-$(CONFIG_ATH10K_SPECTRAL) +=
107 ath10k_core-$(CONFIG_NL80211_TESTMODE) += testmode.o
108 ath10k_core-$(CONFIG_ATH10K_TRACING) += trace.o
109 ath10k_core-$(CONFIG_THERMAL) += thermal.o
110 +ath10k_core-$(CONFIG_ATH10K_LEDS) += leds.o
111 ath10k_core-$(CONFIG_MAC80211_DEBUGFS) += debugfs_sta.o
112 ath10k_core-$(CONFIG_PM) += wow.o
113 ath10k_core-$(CONFIG_DEV_COREDUMP) += coredump.o
114 --- a/ath10k-4.16/core.c
115 +++ b/ath10k-4.16/core.c
117 #include "testmode.h"
119 #include "coredump.h"
122 /* Disable ath10k-ct DBGLOG output by default */
123 unsigned int ath10k_debug_mask = ATH10K_DBG_NO_DBGLOG;
124 @@ -73,6 +74,7 @@ static const struct ath10k_hw_params ath
125 .id = QCA988X_HW_2_0_VERSION,
126 .dev_id = QCA988X_2_0_DEVICE_ID,
127 .name = "qca988x hw2.0",
129 .patch_load_addr = QCA988X_HW_2_0_PATCH_LOAD_ADDR,
131 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
132 @@ -131,6 +133,7 @@ static const struct ath10k_hw_params ath
133 .id = QCA9887_HW_1_0_VERSION,
134 .dev_id = QCA9887_1_0_DEVICE_ID,
135 .name = "qca9887 hw1.0",
137 .patch_load_addr = QCA9887_HW_1_0_PATCH_LOAD_ADDR,
139 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
140 @@ -275,6 +278,7 @@ static const struct ath10k_hw_params ath
141 .id = QCA99X0_HW_2_0_DEV_VERSION,
142 .dev_id = QCA99X0_2_0_DEVICE_ID,
143 .name = "qca99x0 hw2.0",
145 .patch_load_addr = QCA99X0_HW_2_0_PATCH_LOAD_ADDR,
147 .otp_exe_param = 0x00000700,
148 @@ -309,6 +313,7 @@ static const struct ath10k_hw_params ath
149 .id = QCA9984_HW_1_0_DEV_VERSION,
150 .dev_id = QCA9984_1_0_DEVICE_ID,
151 .name = "qca9984/qca9994 hw1.0",
153 .patch_load_addr = QCA9984_HW_1_0_PATCH_LOAD_ADDR,
155 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_EACH,
156 @@ -348,6 +353,7 @@ static const struct ath10k_hw_params ath
157 .id = QCA9888_HW_2_0_DEV_VERSION,
158 .dev_id = QCA9888_2_0_DEVICE_ID,
159 .name = "qca9888 hw2.0",
161 .patch_load_addr = QCA9888_HW_2_0_PATCH_LOAD_ADDR,
163 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_EACH,
164 @@ -3040,6 +3046,10 @@ int ath10k_core_start(struct ath10k *ar,
165 ar->eeprom_overrides.rc_txbf_probe);
168 + status = ath10k_leds_start(ar);
175 @@ -3286,9 +3296,18 @@ static void ath10k_core_register_work(st
176 goto err_spectral_destroy;
179 + status = ath10k_leds_register(ar);
181 + ath10k_err(ar, "could not register leds: %d\n",
183 + goto err_thermal_unregister;
186 set_bit(ATH10K_FLAG_CORE_REGISTERED, &ar->dev_flags);
189 +err_thermal_unregister:
190 + ath10k_thermal_unregister(ar);
191 err_spectral_destroy:
192 ath10k_spectral_destroy(ar);
194 @@ -3346,6 +3365,8 @@ void ath10k_core_unregister(struct ath10
195 if (!test_bit(ATH10K_FLAG_CORE_REGISTERED, &ar->dev_flags))
198 + ath10k_leds_unregister(ar);
200 ath10k_thermal_unregister(ar);
201 /* Stop spectral before unregistering from mac80211 to remove the
202 * relayfs debugfs file cleanly. Otherwise the parent debugfs tree
203 --- a/ath10k-4.16/core.h
204 +++ b/ath10k-4.16/core.h
206 #include <linux/pci.h>
207 #include <linux/uuid.h>
208 #include <linux/time.h>
209 +#include <linux/leds.h>
213 @@ -1245,6 +1246,13 @@ struct ath10k {
217 + struct gpio_led wifi_led;
218 + struct led_classdev cdev;
220 + u32 gpio_state_pin;
224 /* protected by data_lock */
225 u32 fw_crash_counter;
226 u32 fw_warm_reset_counter;
227 --- a/ath10k-4.16/hw.h
228 +++ b/ath10k-4.16/hw.h
229 @@ -499,6 +499,7 @@ struct ath10k_hw_params {
236 /* Type of hw cycle counter wraparound logic, for more info
238 +++ b/ath10k-4.16/leds.c
241 + * Copyright (c) 2005-2011 Atheros Communications Inc.
242 + * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
243 + * Copyright (c) 2018 Sebastian Gottschall <s.gottschall@dd-wrt.com>
244 + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
246 + * Permission to use, copy, modify, and/or distribute this software for any
247 + * purpose with or without fee is hereby granted, provided that the above
248 + * copyright notice and this permission notice appear in all copies.
250 + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
251 + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
252 + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
253 + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
254 + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
255 + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
256 + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
259 +#include <linux/leds.h>
263 +#include "wmi-ops.h"
267 +static int ath10k_leds_set_brightness_blocking(struct led_classdev *led_cdev,
268 + enum led_brightness brightness)
270 + struct ath10k *ar = container_of(led_cdev, struct ath10k,
272 + struct gpio_led *led = &ar->leds.wifi_led;
274 + mutex_lock(&ar->conf_mutex);
276 + if (ar->state != ATH10K_STATE_ON)
279 + ar->leds.gpio_state_pin = (brightness != LED_OFF) ^ led->active_low;
280 + ath10k_wmi_gpio_output(ar, led->gpio, ar->leds.gpio_state_pin);
283 + mutex_unlock(&ar->conf_mutex);
288 +int ath10k_leds_start(struct ath10k *ar)
290 + if (ar->hw_params.led_pin == 0)
291 + /* leds not supported */
294 + /* under some circumstances, the gpio pin gets reconfigured
295 + * to default state by the firmware, so we need to
296 + * reconfigure it this behaviour has only ben seen on
297 + * QCA9984 and QCA99XX devices so far
299 + ath10k_wmi_gpio_config(ar, ar->hw_params.led_pin, 0,
300 + WMI_GPIO_PULL_NONE, WMI_GPIO_INTTYPE_DISABLE);
301 + ath10k_wmi_gpio_output(ar, ar->hw_params.led_pin, 1);
306 +int ath10k_leds_register(struct ath10k *ar)
310 + if (ar->hw_params.led_pin == 0)
311 + /* leds not supported */
314 + snprintf(ar->leds.label, sizeof(ar->leds.label), "ath10k-%s",
315 + wiphy_name(ar->hw->wiphy));
316 + ar->leds.wifi_led.active_low = 1;
317 + ar->leds.wifi_led.gpio = ar->hw_params.led_pin;
318 + ar->leds.wifi_led.name = ar->leds.label;
319 + ar->leds.wifi_led.default_state = LEDS_GPIO_DEFSTATE_KEEP;
321 + ar->leds.cdev.name = ar->leds.label;
322 + ar->leds.cdev.brightness_set_blocking = ath10k_leds_set_brightness_blocking;
324 + /* FIXME: this assignment doesn't make sense as it's NULL, remove it? */
325 + ar->leds.cdev.default_trigger = ar->leds.wifi_led.default_trigger;
327 + ret = led_classdev_register(wiphy_dev(ar->hw->wiphy), &ar->leds.cdev);
334 +void ath10k_leds_unregister(struct ath10k *ar)
336 + if (ar->hw_params.led_pin == 0)
337 + /* leds not supported */
340 + led_classdev_unregister(&ar->leds.cdev);
344 +++ b/ath10k-4.16/leds.h
347 + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
349 + * Permission to use, copy, modify, and/or distribute this software for any
350 + * purpose with or without fee is hereby granted, provided that the above
351 + * copyright notice and this permission notice appear in all copies.
353 + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
354 + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
355 + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
356 + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
357 + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
358 + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
359 + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
366 +#ifdef CONFIG_ATH10K_LEDS
367 +void ath10k_leds_unregister(struct ath10k *ar);
368 +int ath10k_leds_start(struct ath10k *ar);
369 +int ath10k_leds_register(struct ath10k *ar);
371 +static inline void ath10k_leds_unregister(struct ath10k *ar)
375 +static inline int ath10k_leds_start(struct ath10k *ar)
380 +static inline int ath10k_leds_register(struct ath10k *ar)
386 +#endif /* _LEDS_H_ */
387 --- a/ath10k-4.16/mac.c
388 +++ b/ath10k-4.16/mac.c
397 --- a/ath10k-4.16/wmi-ops.h
398 +++ b/ath10k-4.16/wmi-ops.h
399 @@ -199,6 +199,9 @@ struct wmi_ops {
401 enum wmi_bss_survey_req_type type);
402 struct sk_buff *(*gen_echo)(struct ath10k *ar, u32 value);
403 + struct sk_buff *(*gen_gpio_config)(struct ath10k *ar, u32 gpio_num,
404 + u32 input, u32 pull_type, u32 intr_mode);
405 + struct sk_buff *(*gen_gpio_output)(struct ath10k *ar, u32 gpio_num, u32 set);
408 int ath10k_wmi_cmd_send(struct ath10k *ar, struct sk_buff *skb, u32 cmd_id);
409 @@ -975,6 +978,35 @@ ath10k_wmi_force_fw_hang(struct ath10k *
410 return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->force_fw_hang_cmdid);
413 +static inline int ath10k_wmi_gpio_config(struct ath10k *ar, u32 gpio_num,
414 + u32 input, u32 pull_type, u32 intr_mode)
416 + struct sk_buff *skb;
418 + if (!ar->wmi.ops->gen_gpio_config)
419 + return -EOPNOTSUPP;
421 + skb = ar->wmi.ops->gen_gpio_config(ar, gpio_num, input, pull_type, intr_mode);
423 + return PTR_ERR(skb);
425 + return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->gpio_config_cmdid);
428 +static inline int ath10k_wmi_gpio_output(struct ath10k *ar, u32 gpio_num, u32 set)
430 + struct sk_buff *skb;
432 + if (!ar->wmi.ops->gen_gpio_config)
433 + return -EOPNOTSUPP;
435 + skb = ar->wmi.ops->gen_gpio_output(ar, gpio_num, set);
437 + return PTR_ERR(skb);
439 + return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->gpio_output_cmdid);
443 ath10k_wmi_dbglog_cfg(struct ath10k *ar, u64 module_enable, u32 log_level)
445 --- a/ath10k-4.16/wmi-tlv.c
446 +++ b/ath10k-4.16/wmi-tlv.c
447 @@ -3729,6 +3729,8 @@ static const struct wmi_ops wmi_tlv_ops
448 .gen_echo = ath10k_wmi_tlv_op_gen_echo,
449 .gen_vdev_spectral_conf = ath10k_wmi_tlv_op_gen_vdev_spectral_conf,
450 .gen_vdev_spectral_enable = ath10k_wmi_tlv_op_gen_vdev_spectral_enable,
451 + /* .gen_gpio_config not implemented */
452 + /* .gen_gpio_output not implemented */
455 static const struct wmi_peer_flags_map wmi_tlv_peer_flags_map = {
456 --- a/ath10k-4.16/wmi.c
457 +++ b/ath10k-4.16/wmi.c
458 @@ -7325,6 +7325,49 @@ ath10k_wmi_op_gen_peer_set_param(struct
462 +static struct sk_buff *ath10k_wmi_op_gen_gpio_config(struct ath10k *ar,
463 + u32 gpio_num, u32 input,
464 + u32 pull_type, u32 intr_mode)
466 + struct wmi_gpio_config_cmd *cmd;
467 + struct sk_buff *skb;
469 + skb = ath10k_wmi_alloc_skb(ar, sizeof(*cmd));
471 + return ERR_PTR(-ENOMEM);
473 + cmd = (struct wmi_gpio_config_cmd *)skb->data;
474 + cmd->pull_type = __cpu_to_le32(pull_type);
475 + cmd->gpio_num = __cpu_to_le32(gpio_num);
476 + cmd->input = __cpu_to_le32(input);
477 + cmd->intr_mode = __cpu_to_le32(intr_mode);
479 + ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi gpio_config gpio_num 0x%08x input 0x%08x pull_type 0x%08x intr_mode 0x%08x\n",
480 + gpio_num, input, pull_type, intr_mode);
485 +static struct sk_buff *ath10k_wmi_op_gen_gpio_output(struct ath10k *ar,
486 + u32 gpio_num, u32 set)
488 + struct wmi_gpio_output_cmd *cmd;
489 + struct sk_buff *skb;
491 + skb = ath10k_wmi_alloc_skb(ar, sizeof(*cmd));
493 + return ERR_PTR(-ENOMEM);
495 + cmd = (struct wmi_gpio_output_cmd *)skb->data;
496 + cmd->gpio_num = __cpu_to_le32(gpio_num);
497 + cmd->set = __cpu_to_le32(set);
499 + ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi gpio_output gpio_num 0x%08x set 0x%08x\n",
505 static struct sk_buff *
506 ath10k_wmi_op_gen_set_psmode(struct ath10k *ar, u32 vdev_id,
507 enum wmi_sta_ps_mode psmode)
508 @@ -8940,6 +8983,9 @@ static const struct wmi_ops wmi_ops = {
509 .fw_stats_fill = ath10k_wmi_main_op_fw_stats_fill,
510 .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
511 .gen_echo = ath10k_wmi_op_gen_echo,
512 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
513 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
515 /* .gen_bcn_tmpl not implemented */
516 /* .gen_prb_tmpl not implemented */
517 /* .gen_p2p_go_bcn_ie not implemented */
518 @@ -9010,6 +9056,8 @@ static const struct wmi_ops wmi_10_1_ops
519 .fw_stats_fill = ath10k_wmi_10x_op_fw_stats_fill,
520 .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
521 .gen_echo = ath10k_wmi_op_gen_echo,
522 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
523 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
524 /* .gen_bcn_tmpl not implemented */
525 /* .gen_prb_tmpl not implemented */
526 /* .gen_p2p_go_bcn_ie not implemented */
527 @@ -9087,6 +9135,8 @@ static const struct wmi_ops wmi_10_2_ops
528 .gen_delba_send = ath10k_wmi_op_gen_delba_send,
529 .fw_stats_fill = ath10k_wmi_10x_op_fw_stats_fill,
530 .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
531 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
532 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
533 /* .gen_pdev_enable_adaptive_cca not implemented */
536 @@ -9157,6 +9207,8 @@ static const struct wmi_ops wmi_10_2_4_o
537 .gen_pdev_enable_adaptive_cca =
538 ath10k_wmi_op_gen_pdev_enable_adaptive_cca,
539 .get_vdev_subtype = ath10k_wmi_10_2_4_op_get_vdev_subtype,
540 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
541 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
542 /* .gen_bcn_tmpl not implemented */
543 /* .gen_prb_tmpl not implemented */
544 /* .gen_p2p_go_bcn_ie not implemented */
545 @@ -9233,6 +9285,8 @@ static const struct wmi_ops wmi_10_4_ops
546 .gen_pdev_bss_chan_info_req = ath10k_wmi_10_2_op_gen_pdev_bss_chan_info,
547 .gen_echo = ath10k_wmi_op_gen_echo,
548 .gen_pdev_get_tpc_config = ath10k_wmi_10_2_4_op_gen_pdev_get_tpc_config,
549 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
550 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
553 int ath10k_wmi_attach(struct ath10k *ar)
554 --- a/ath10k-4.16/wmi.h
555 +++ b/ath10k-4.16/wmi.h
556 @@ -3000,6 +3000,41 @@ enum wmi_10_4_feature_mask {
560 +/* WMI_GPIO_CONFIG_CMDID */
562 + WMI_GPIO_PULL_NONE,
564 + WMI_GPIO_PULL_DOWN,
568 + WMI_GPIO_INTTYPE_DISABLE,
569 + WMI_GPIO_INTTYPE_RISING_EDGE,
570 + WMI_GPIO_INTTYPE_FALLING_EDGE,
571 + WMI_GPIO_INTTYPE_BOTH_EDGE,
572 + WMI_GPIO_INTTYPE_LEVEL_LOW,
573 + WMI_GPIO_INTTYPE_LEVEL_HIGH
576 +/* WMI_GPIO_CONFIG_CMDID */
577 +struct wmi_gpio_config_cmd {
578 + __le32 gpio_num; /* GPIO number to be setup */
579 + __le32 input; /* 0 - Output/ 1 - Input */
580 + __le32 pull_type; /* Pull type defined above */
581 + __le32 intr_mode; /* Interrupt mode defined above (Input) */
584 +/* WMI_GPIO_OUTPUT_CMDID */
585 +struct wmi_gpio_output_cmd {
586 + __le32 gpio_num; /* GPIO number to be setup */
587 + __le32 set; /* Set the GPIO pin*/
590 +/* WMI_GPIO_INPUT_EVENTID */
591 +struct wmi_gpio_input_event {
592 + __le32 gpio_num; /* GPIO number which changed state */
595 struct wmi_ext_resource_config_10_4_cmd {
596 /* contains enum wmi_host_platform_type */
597 __le32 host_platform_config;
598 --- a/ath10k-4.19/Kconfig
599 +++ b/ath10k-4.19/Kconfig
600 @@ -64,6 +64,16 @@ config ATH10K_DEBUGFS
602 If unsure, say Y to make it easier to debug problems.
605 + bool "Atheros ath10k LED support"
607 + select MAC80211_LEDS
612 + This option is necessary, if you want LED support for chipset connected led pins. If unsure, say N.
614 config ATH10K_SPECTRAL
615 bool "Atheros ath10k spectral scan support"
616 depends on ATH10K_DEBUGFS
617 --- a/ath10k-4.19/Makefile
618 +++ b/ath10k-4.19/Makefile
619 @@ -19,6 +19,7 @@ ath10k_core-$(CONFIG_ATH10K_SPECTRAL) +=
620 ath10k_core-$(CONFIG_NL80211_TESTMODE) += testmode.o
621 ath10k_core-$(CONFIG_ATH10K_TRACING) += trace.o
622 ath10k_core-$(CONFIG_THERMAL) += thermal.o
623 +ath10k_core-$(CONFIG_ATH10K_LEDS) += leds.o
624 ath10k_core-$(CONFIG_MAC80211_DEBUGFS) += debugfs_sta.o
625 ath10k_core-$(CONFIG_PM) += wow.o
626 ath10k_core-$(CONFIG_DEV_COREDUMP) += coredump.o
627 --- a/ath10k-4.19/core.c
628 +++ b/ath10k-4.19/core.c
630 #include "testmode.h"
632 #include "coredump.h"
635 /* Disable ath10k-ct DBGLOG output by default */
636 unsigned int ath10k_debug_mask = ATH10K_DBG_NO_DBGLOG;
637 @@ -72,6 +73,7 @@ static const struct ath10k_hw_params ath
638 .id = QCA988X_HW_2_0_VERSION,
639 .dev_id = QCA988X_2_0_DEVICE_ID,
640 .name = "qca988x hw2.0",
642 .patch_load_addr = QCA988X_HW_2_0_PATCH_LOAD_ADDR,
644 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
645 @@ -137,6 +139,7 @@ static const struct ath10k_hw_params ath
646 .id = QCA9887_HW_1_0_VERSION,
647 .dev_id = QCA9887_1_0_DEVICE_ID,
648 .name = "qca9887 hw1.0",
650 .patch_load_addr = QCA9887_HW_1_0_PATCH_LOAD_ADDR,
652 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
653 @@ -301,6 +304,7 @@ static const struct ath10k_hw_params ath
654 .id = QCA99X0_HW_2_0_DEV_VERSION,
655 .dev_id = QCA99X0_2_0_DEVICE_ID,
656 .name = "qca99x0 hw2.0",
658 .patch_load_addr = QCA99X0_HW_2_0_PATCH_LOAD_ADDR,
660 .otp_exe_param = 0x00000700,
661 @@ -339,6 +343,7 @@ static const struct ath10k_hw_params ath
662 .id = QCA9984_HW_1_0_DEV_VERSION,
663 .dev_id = QCA9984_1_0_DEVICE_ID,
664 .name = "qca9984/qca9994 hw1.0",
666 .patch_load_addr = QCA9984_HW_1_0_PATCH_LOAD_ADDR,
668 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_EACH,
669 @@ -382,6 +387,7 @@ static const struct ath10k_hw_params ath
670 .id = QCA9888_HW_2_0_DEV_VERSION,
671 .dev_id = QCA9888_2_0_DEVICE_ID,
672 .name = "qca9888 hw2.0",
674 .patch_load_addr = QCA9888_HW_2_0_PATCH_LOAD_ADDR,
676 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_EACH,
677 @@ -3102,6 +3108,10 @@ int ath10k_core_start(struct ath10k *ar,
678 ar->eeprom_overrides.rc_txbf_probe);
681 + status = ath10k_leds_start(ar);
688 @@ -3356,9 +3366,18 @@ static void ath10k_core_register_work(st
689 goto err_spectral_destroy;
692 + status = ath10k_leds_register(ar);
694 + ath10k_err(ar, "could not register leds: %d\n",
696 + goto err_thermal_unregister;
699 set_bit(ATH10K_FLAG_CORE_REGISTERED, &ar->dev_flags);
702 +err_thermal_unregister:
703 + ath10k_thermal_unregister(ar);
704 err_spectral_destroy:
705 ath10k_spectral_destroy(ar);
707 @@ -3416,6 +3435,8 @@ void ath10k_core_unregister(struct ath10
708 if (!test_bit(ATH10K_FLAG_CORE_REGISTERED, &ar->dev_flags))
711 + ath10k_leds_unregister(ar);
713 ath10k_thermal_unregister(ar);
714 /* Stop spectral before unregistering from mac80211 to remove the
715 * relayfs debugfs file cleanly. Otherwise the parent debugfs tree
716 --- a/ath10k-4.19/core.h
717 +++ b/ath10k-4.19/core.h
719 #include <linux/pci.h>
720 #include <linux/uuid.h>
721 #include <linux/time.h>
722 +#include <linux/leds.h>
726 @@ -1106,7 +1107,6 @@ struct ath10k {
732 bool ct_all_pkts_htt; /* CT firmware only: native-wifi for all pkts */
734 @@ -1355,6 +1355,13 @@ struct ath10k {
738 + struct gpio_led wifi_led;
739 + struct led_classdev cdev;
741 + u32 gpio_state_pin;
745 /* protected by data_lock */
746 u32 fw_crash_counter;
747 u32 fw_warm_reset_counter;
748 --- a/ath10k-4.19/hw.h
749 +++ b/ath10k-4.19/hw.h
750 @@ -508,6 +508,7 @@ struct ath10k_hw_params {
757 /* Type of hw cycle counter wraparound logic, for more info
759 +++ b/ath10k-4.19/leds.c
762 + * Copyright (c) 2005-2011 Atheros Communications Inc.
763 + * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
764 + * Copyright (c) 2018 Sebastian Gottschall <s.gottschall@dd-wrt.com>
765 + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
767 + * Permission to use, copy, modify, and/or distribute this software for any
768 + * purpose with or without fee is hereby granted, provided that the above
769 + * copyright notice and this permission notice appear in all copies.
771 + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
772 + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
773 + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
774 + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
775 + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
776 + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
777 + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
780 +#include <linux/leds.h>
784 +#include "wmi-ops.h"
788 +static int ath10k_leds_set_brightness_blocking(struct led_classdev *led_cdev,
789 + enum led_brightness brightness)
791 + struct ath10k *ar = container_of(led_cdev, struct ath10k,
793 + struct gpio_led *led = &ar->leds.wifi_led;
795 + mutex_lock(&ar->conf_mutex);
797 + if (ar->state != ATH10K_STATE_ON)
800 + ar->leds.gpio_state_pin = (brightness != LED_OFF) ^ led->active_low;
801 + ath10k_wmi_gpio_output(ar, led->gpio, ar->leds.gpio_state_pin);
804 + mutex_unlock(&ar->conf_mutex);
809 +int ath10k_leds_start(struct ath10k *ar)
811 + if (ar->hw_params.led_pin == 0)
812 + /* leds not supported */
815 + /* under some circumstances, the gpio pin gets reconfigured
816 + * to default state by the firmware, so we need to
817 + * reconfigure it this behaviour has only ben seen on
818 + * QCA9984 and QCA99XX devices so far
820 + ath10k_wmi_gpio_config(ar, ar->hw_params.led_pin, 0,
821 + WMI_GPIO_PULL_NONE, WMI_GPIO_INTTYPE_DISABLE);
822 + ath10k_wmi_gpio_output(ar, ar->hw_params.led_pin, 1);
827 +int ath10k_leds_register(struct ath10k *ar)
831 + if (ar->hw_params.led_pin == 0)
832 + /* leds not supported */
835 + snprintf(ar->leds.label, sizeof(ar->leds.label), "ath10k-%s",
836 + wiphy_name(ar->hw->wiphy));
837 + ar->leds.wifi_led.active_low = 1;
838 + ar->leds.wifi_led.gpio = ar->hw_params.led_pin;
839 + ar->leds.wifi_led.name = ar->leds.label;
840 + ar->leds.wifi_led.default_state = LEDS_GPIO_DEFSTATE_KEEP;
842 + ar->leds.cdev.name = ar->leds.label;
843 + ar->leds.cdev.brightness_set_blocking = ath10k_leds_set_brightness_blocking;
845 + /* FIXME: this assignment doesn't make sense as it's NULL, remove it? */
846 + ar->leds.cdev.default_trigger = ar->leds.wifi_led.default_trigger;
848 + ret = led_classdev_register(wiphy_dev(ar->hw->wiphy), &ar->leds.cdev);
855 +void ath10k_leds_unregister(struct ath10k *ar)
857 + if (ar->hw_params.led_pin == 0)
858 + /* leds not supported */
861 + led_classdev_unregister(&ar->leds.cdev);
865 +++ b/ath10k-4.19/leds.h
868 + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
870 + * Permission to use, copy, modify, and/or distribute this software for any
871 + * purpose with or without fee is hereby granted, provided that the above
872 + * copyright notice and this permission notice appear in all copies.
874 + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
875 + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
876 + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
877 + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
878 + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
879 + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
880 + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
887 +#ifdef CONFIG_ATH10K_LEDS
888 +void ath10k_leds_unregister(struct ath10k *ar);
889 +int ath10k_leds_start(struct ath10k *ar);
890 +int ath10k_leds_register(struct ath10k *ar);
892 +static inline void ath10k_leds_unregister(struct ath10k *ar)
896 +static inline int ath10k_leds_start(struct ath10k *ar)
901 +static inline int ath10k_leds_register(struct ath10k *ar)
907 +#endif /* _LEDS_H_ */
908 --- a/ath10k-4.19/mac.c
909 +++ b/ath10k-4.19/mac.c
918 --- a/ath10k-4.19/wmi-ops.h
919 +++ b/ath10k-4.19/wmi-ops.h
920 @@ -218,7 +218,10 @@ struct wmi_ops {
921 struct sk_buff *(*gen_echo)(struct ath10k *ar, u32 value);
922 struct sk_buff *(*gen_pdev_get_tpc_table_cmdid)(struct ath10k *ar,
924 + struct sk_buff *(*gen_gpio_config)(struct ath10k *ar, u32 gpio_num,
925 + u32 input, u32 pull_type, u32 intr_mode);
927 + struct sk_buff *(*gen_gpio_output)(struct ath10k *ar, u32 gpio_num, u32 set);
930 int ath10k_wmi_cmd_send(struct ath10k *ar, struct sk_buff *skb, u32 cmd_id);
931 @@ -1071,6 +1074,35 @@ ath10k_wmi_force_fw_hang(struct ath10k *
932 return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->force_fw_hang_cmdid);
935 +static inline int ath10k_wmi_gpio_config(struct ath10k *ar, u32 gpio_num,
936 + u32 input, u32 pull_type, u32 intr_mode)
938 + struct sk_buff *skb;
940 + if (!ar->wmi.ops->gen_gpio_config)
941 + return -EOPNOTSUPP;
943 + skb = ar->wmi.ops->gen_gpio_config(ar, gpio_num, input, pull_type, intr_mode);
945 + return PTR_ERR(skb);
947 + return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->gpio_config_cmdid);
950 +static inline int ath10k_wmi_gpio_output(struct ath10k *ar, u32 gpio_num, u32 set)
952 + struct sk_buff *skb;
954 + if (!ar->wmi.ops->gen_gpio_config)
955 + return -EOPNOTSUPP;
957 + skb = ar->wmi.ops->gen_gpio_output(ar, gpio_num, set);
959 + return PTR_ERR(skb);
961 + return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->gpio_output_cmdid);
965 ath10k_wmi_dbglog_cfg(struct ath10k *ar, u64 module_enable, u32 log_level)
967 --- a/ath10k-4.19/wmi-tlv.c
968 +++ b/ath10k-4.19/wmi-tlv.c
969 @@ -3976,6 +3976,8 @@ static const struct wmi_ops wmi_tlv_ops
970 .gen_echo = ath10k_wmi_tlv_op_gen_echo,
971 .gen_vdev_spectral_conf = ath10k_wmi_tlv_op_gen_vdev_spectral_conf,
972 .gen_vdev_spectral_enable = ath10k_wmi_tlv_op_gen_vdev_spectral_enable,
973 + /* .gen_gpio_config not implemented */
974 + /* .gen_gpio_output not implemented */
977 static const struct wmi_peer_flags_map wmi_tlv_peer_flags_map = {
978 --- a/ath10k-4.19/wmi.c
979 +++ b/ath10k-4.19/wmi.c
980 @@ -7844,6 +7844,49 @@ ath10k_wmi_op_gen_peer_set_param(struct
984 +static struct sk_buff *ath10k_wmi_op_gen_gpio_config(struct ath10k *ar,
985 + u32 gpio_num, u32 input,
986 + u32 pull_type, u32 intr_mode)
988 + struct wmi_gpio_config_cmd *cmd;
989 + struct sk_buff *skb;
991 + skb = ath10k_wmi_alloc_skb(ar, sizeof(*cmd));
993 + return ERR_PTR(-ENOMEM);
995 + cmd = (struct wmi_gpio_config_cmd *)skb->data;
996 + cmd->pull_type = __cpu_to_le32(pull_type);
997 + cmd->gpio_num = __cpu_to_le32(gpio_num);
998 + cmd->input = __cpu_to_le32(input);
999 + cmd->intr_mode = __cpu_to_le32(intr_mode);
1001 + ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi gpio_config gpio_num 0x%08x input 0x%08x pull_type 0x%08x intr_mode 0x%08x\n",
1002 + gpio_num, input, pull_type, intr_mode);
1007 +static struct sk_buff *ath10k_wmi_op_gen_gpio_output(struct ath10k *ar,
1008 + u32 gpio_num, u32 set)
1010 + struct wmi_gpio_output_cmd *cmd;
1011 + struct sk_buff *skb;
1013 + skb = ath10k_wmi_alloc_skb(ar, sizeof(*cmd));
1015 + return ERR_PTR(-ENOMEM);
1017 + cmd = (struct wmi_gpio_output_cmd *)skb->data;
1018 + cmd->gpio_num = __cpu_to_le32(gpio_num);
1019 + cmd->set = __cpu_to_le32(set);
1021 + ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi gpio_output gpio_num 0x%08x set 0x%08x\n",
1027 static struct sk_buff *
1028 ath10k_wmi_op_gen_set_psmode(struct ath10k *ar, u32 vdev_id,
1029 enum wmi_sta_ps_mode psmode)
1030 @@ -9568,6 +9611,9 @@ static const struct wmi_ops wmi_ops = {
1031 .fw_stats_fill = ath10k_wmi_main_op_fw_stats_fill,
1032 .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
1033 .gen_echo = ath10k_wmi_op_gen_echo,
1034 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
1035 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
1037 /* .gen_bcn_tmpl not implemented */
1038 /* .gen_prb_tmpl not implemented */
1039 /* .gen_p2p_go_bcn_ie not implemented */
1040 @@ -9638,6 +9684,8 @@ static const struct wmi_ops wmi_10_1_ops
1041 .fw_stats_fill = ath10k_wmi_10x_op_fw_stats_fill,
1042 .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
1043 .gen_echo = ath10k_wmi_op_gen_echo,
1044 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
1045 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
1046 /* .gen_bcn_tmpl not implemented */
1047 /* .gen_prb_tmpl not implemented */
1048 /* .gen_p2p_go_bcn_ie not implemented */
1049 @@ -9715,6 +9763,8 @@ static const struct wmi_ops wmi_10_2_ops
1050 .gen_delba_send = ath10k_wmi_op_gen_delba_send,
1051 .fw_stats_fill = ath10k_wmi_10x_op_fw_stats_fill,
1052 .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
1053 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
1054 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
1055 /* .gen_pdev_enable_adaptive_cca not implemented */
1058 @@ -9785,6 +9835,8 @@ static const struct wmi_ops wmi_10_2_4_o
1059 .gen_pdev_enable_adaptive_cca =
1060 ath10k_wmi_op_gen_pdev_enable_adaptive_cca,
1061 .get_vdev_subtype = ath10k_wmi_10_2_4_op_get_vdev_subtype,
1062 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
1063 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
1064 /* .gen_bcn_tmpl not implemented */
1065 /* .gen_prb_tmpl not implemented */
1066 /* .gen_p2p_go_bcn_ie not implemented */
1067 @@ -9865,6 +9917,8 @@ static const struct wmi_ops wmi_10_4_ops
1068 .gen_pdev_bss_chan_info_req = ath10k_wmi_10_2_op_gen_pdev_bss_chan_info,
1069 .gen_echo = ath10k_wmi_op_gen_echo,
1070 .gen_pdev_get_tpc_config = ath10k_wmi_10_2_4_op_gen_pdev_get_tpc_config,
1071 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
1072 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
1075 int ath10k_wmi_attach(struct ath10k *ar)
1076 --- a/ath10k-4.19/wmi.h
1077 +++ b/ath10k-4.19/wmi.h
1078 @@ -3038,6 +3038,41 @@ enum wmi_10_4_feature_mask {
1082 +/* WMI_GPIO_CONFIG_CMDID */
1084 + WMI_GPIO_PULL_NONE,
1086 + WMI_GPIO_PULL_DOWN,
1090 + WMI_GPIO_INTTYPE_DISABLE,
1091 + WMI_GPIO_INTTYPE_RISING_EDGE,
1092 + WMI_GPIO_INTTYPE_FALLING_EDGE,
1093 + WMI_GPIO_INTTYPE_BOTH_EDGE,
1094 + WMI_GPIO_INTTYPE_LEVEL_LOW,
1095 + WMI_GPIO_INTTYPE_LEVEL_HIGH
1098 +/* WMI_GPIO_CONFIG_CMDID */
1099 +struct wmi_gpio_config_cmd {
1100 + __le32 gpio_num; /* GPIO number to be setup */
1101 + __le32 input; /* 0 - Output/ 1 - Input */
1102 + __le32 pull_type; /* Pull type defined above */
1103 + __le32 intr_mode; /* Interrupt mode defined above (Input) */
1106 +/* WMI_GPIO_OUTPUT_CMDID */
1107 +struct wmi_gpio_output_cmd {
1108 + __le32 gpio_num; /* GPIO number to be setup */
1109 + __le32 set; /* Set the GPIO pin*/
1112 +/* WMI_GPIO_INPUT_EVENTID */
1113 +struct wmi_gpio_input_event {
1114 + __le32 gpio_num; /* GPIO number which changed state */
1117 struct wmi_ext_resource_config_10_4_cmd {
1118 /* contains enum wmi_host_platform_type */
1119 __le32 host_platform_config;