git.openwrt.org Git - openwrt/staging/wigyori.git/blob

   1 From f2ec98566775dd4341ec1dcf93aa5859c60de826 Mon Sep 17 00:00:00 2001
   2 From: Christian Marangi <ansuelsmth@gmail.com>
   3 Date: Thu, 1 Feb 2024 14:46:00 +0100
   4 Subject: [PATCH 1/2] net: phy: qcom: qca808x: fix logic error in LED
   5  brightness set
   6
   7 In switching to using phy_modify_mmd and a more short version of the
   8 LED ON/OFF condition in later revision, it was made a logic error where
   9
  10 value ? QCA808X_LED_FORCE_ON : QCA808X_LED_FORCE_OFF is always true as
  11 value is always OR with QCA808X_LED_FORCE_EN due to missing ()
  12 resulting in the testing condition being QCA808X_LED_FORCE_EN | value.
  13
  14 Add the () to apply the correct condition and restore correct
  15 functionality of the brightness ON/OFF.
  16
  17 Fixes: 7196062b64ee ("net: phy: at803x: add LED support for qca808x")
  18 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
  19 Signed-off-by: David S. Miller <davem@davemloft.net>
  20 ---
  21  drivers/net/phy/qcom/qca808x.c | 4 ++--
  22  1 file changed, 2 insertions(+), 2 deletions(-)
  23
  24 --- a/drivers/net/phy/qcom/qca808x.c
  25 +++ b/drivers/net/phy/qcom/qca808x.c
  26 @@ -820,8 +820,8 @@ static int qca808x_led_brightness_set(st
  27
  28         return phy_modify_mmd(phydev, MDIO_MMD_AN, reg,
  29                               QCA808X_LED_FORCE_EN | QCA808X_LED_FORCE_MODE_MASK,
  30 -                             QCA808X_LED_FORCE_EN | value ? QCA808X_LED_FORCE_ON :
  31 -                                                            QCA808X_LED_FORCE_OFF);
  32 +                             QCA808X_LED_FORCE_EN | (value ? QCA808X_LED_FORCE_ON :
  33 +                                                            QCA808X_LED_FORCE_OFF));
  34  }
  35
  36  static int qca808x_led_blink_set(struct phy_device *phydev, u8 index,